This repository was archived by the owner on Nov 7, 2025. It is now read-only.
Accept new DateTime format (with timezone) in ids query
#1489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/run-it |
Member
Author
|
/run-it |
trzysiek
force-pushed
the
1488-ids-new-time-format
branch
from
f8d02b6 to
a8a2996
Compare
trzysiek
force-pushed
the
1488-ids-new-time-format
branch
from
a8a2996 to
b733344
Compare
trzysiek
changed the title
ids queryids query
Member
Author
|
/run-it |
Contributor
|
@trzysiek Thank you for that! |
pdelewski
approved these changes
Jul 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing feature from #1488
Before - we only accepted either dates with no timezone, or trickily removed
+00:00 UTC(thus only to accept this timezone). Other timezones resulted in an error and our error response.Now - we properly parse the entire date with timezone, and it works e.g. for the user's
+0200 CEST.I reproduced the error, after this PR it no longer appears (tested
idsquery manually, which is the only 1 where this error occured, and it properly returned my record from Clickhouse)